-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove styles for details.undocumented #91099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Rust code that generated tags with that class was deleted in 10bafe1.
Some changes occurred in HTML/CSS/JS. |
Thanks! I'm pretty sure there are a lot of unused CSS but it's hard to keep track... Do you know of a tool we could use for that maybe? @bors: r+ rollup |
📌 Commit 6354b27 has been approved by |
…umeGomez Remove styles for details.undocumented The Rust code that generated tags with that class was deleted in 10bafe1. r? `@GuillaumeGomez`
Chrome Developer Tools has a code coverage tool (https://developer.chrome.com/docs/devtools/coverage/). It's pretty cool! I've tried it on rustdoc. It's a good starting point but you still need to do some manual investigation after getting initial results from it because there are certain styles that only show up on some pages, or in some rare documentation situations. |
We need to go through all different kind of pages (module and types) and have all of them available in a module as well. Just running it on the std docs should maybe cover most of it. That could be worth a try. |
…umeGomez Remove styles for details.undocumented The Rust code that generated tags with that class was deleted in 10bafe1. r? `@GuillaumeGomez`
…umeGomez Remove styles for details.undocumented The Rust code that generated tags with that class was deleted in 10bafe1. r? ``@GuillaumeGomez``
☀️ Test successful - checks-actions |
Finished benchmarking commit (cd83a43): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
The Rust code that generated tags with that class was deleted in
10bafe1.
r? @GuillaumeGomez