Skip to content

Remove styles for details.undocumented #91099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 21, 2021

The Rust code that generated tags with that class was deleted in
10bafe1.

r? @GuillaumeGomez

The Rust code that generated tags with that class was deleted in
10bafe1.
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Nov 21, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2021
@GuillaumeGomez
Copy link
Member

Thanks! I'm pretty sure there are a lot of unused CSS but it's hard to keep track... Do you know of a tool we could use for that maybe?

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 21, 2021

📌 Commit 6354b27 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 21, 2021
…umeGomez

Remove styles for details.undocumented

The Rust code that generated tags with that class was deleted in
10bafe1.

r? `@GuillaumeGomez`
@jsha
Copy link
Contributor Author

jsha commented Nov 21, 2021

Chrome Developer Tools has a code coverage tool (https://developer.chrome.com/docs/devtools/coverage/). It's pretty cool! I've tried it on rustdoc. It's a good starting point but you still need to do some manual investigation after getting initial results from it because there are certain styles that only show up on some pages, or in some rare documentation situations.

@GuillaumeGomez
Copy link
Member

We need to go through all different kind of pages (module and types) and have all of them available in a module as well. Just running it on the std docs should maybe cover most of it. That could be worth a try.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 21, 2021
…umeGomez

Remove styles for details.undocumented

The Rust code that generated tags with that class was deleted in
10bafe1.

r? `@GuillaumeGomez`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 21, 2021
…umeGomez

Remove styles for details.undocumented

The Rust code that generated tags with that class was deleted in
10bafe1.

r? ``@GuillaumeGomez``
@bors
Copy link
Collaborator

bors commented Nov 22, 2021

⌛ Testing commit 6354b27 with merge cd83a43...

@bors
Copy link
Collaborator

bors commented Nov 22, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing cd83a43 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2021
@bors bors merged commit cd83a43 into rust-lang:master Nov 22, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 22, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cd83a43): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants