Move glob tests to a run-pass test #9170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we instead move this test into |
The normal unit tests cannot change the current working directory because it messes with the other tests which depend on a particular working directory.
bors
added a commit
that referenced
this pull request
Sep 13, 2013
The glob tests cannot change the current working directory because the other tests (namely the fileinput ones) depend on the current working directory not changing.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
[`box_collection`]: raise warn for all std collections So far, only [`Vec`, `String`, `HashMap`] were considered. Extend collection checklist for this lint with: - `HashSet` - `VecDeque` - `LinkedList` - `BTreeMap` - `BTreeSet` - `BinaryHeap` changelog: [`box_collection`]: raise warn for all std collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob tests cannot change the current working directory because the other tests (namely the fileinput ones) depend on the current working directory not changing.