Skip to content

Rollup of 6 pull requests #91825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 12, 2021
Merged

Rollup of 6 pull requests #91825

merged 13 commits into from
Dec 12, 2021

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ssomers and others added 13 commits December 10, 2021 16:22
On Windows, `x.py dist` command panics without proper error message if 'WIX' environment variable is not set. This patch changes `Option::unwrap()` to `Option::expect()`.
dereferencable -> dereferenceable
This commit adds autolabeling for the `T-rustdoc` label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.
Btree: assert more API compatibility

Introducing a member such as `BTreeSet::min()` would silently break compatibility if no code calls the existing `BTreeSet::min(set)`. `BTreeSet` is the only btree class silently bringing in stable members, apart from many occurrences of `#[derive(Debug)]` on iterators.

r? `@Mark-Simulacrum`
…it-mut_t_is_not_an_iterator, r=Mark-Simulacrum

rustdoc: Add regression test for Iterator as notable trait on &mut T

Closes rust-lang#80737
…issue, r=Mark-Simulacrum

bootstrap: Change unwrap() to expect() for WIX path

On Windows, `x.py dist` command panics without proper error message if `WIX` environment variable is not set. This patch changes `Option::unwrap()` to `Option::expect()`.
doc: fix typo in comments

`dereferencable -> dereferenceable`

Fixes rust-lang#91802.
better span for unexpected normalization failure in CTFE engine

No reason to use `DUMMY_SP` here.
…-Simulacrum

rustbot: Add autolabeling for `T-rustdoc`

This commit adds autolabeling for the `T-rustdoc` label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.
@rustbot rustbot added the rollup A PR which is a rollup label Dec 12, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Collaborator

bors commented Dec 12, 2021

📌 Commit 479e189 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 12, 2021
@bors
Copy link
Collaborator

bors commented Dec 12, 2021

⌛ Testing commit 479e189 with merge a0a4c7d...

@bors
Copy link
Collaborator

bors commented Dec 12, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a0a4c7d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2021
@bors bors merged commit a0a4c7d into rust-lang:master Dec 12, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 12, 2021
@matthiaskrgr matthiaskrgr deleted the rollup-e4s8lwp branch December 12, 2021 09:58
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a0a4c7d): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2021

Error: Malformed triagebot.toml in master branch.
missing field trigger_labels for key autolabel at line 156 column 1

Please let @rust-lang/release know if you're having trouble with this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants