Skip to content

rust: Don't call libc::exit #9471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rust: Don't call libc::exit #9471

wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 24, 2013

This appears to eliminate the common errors with assertions failures
in rust_initialize_rt_tls_key.

This appears to eliminate the common errors with assertions failures
in rust_initialize_rt_tls_key.
@thestinger
Copy link
Contributor

I guess this is caused by the atexit handlers?

I think we could expose a safe wrapper around abort or _exit at some point because it's no less unsafe than going out-of-memory or sending a SIGKILL signal to yourself.

bors added a commit that referenced this pull request Sep 24, 2013
This appears to eliminate the common errors with assertions failures
in rust_initialize_rt_tls_key.
@brson
Copy link
Contributor Author

brson commented Sep 24, 2013

cc #8870

@brson
Copy link
Contributor Author

brson commented Sep 24, 2013

@thestinger I don't know that it's caused by atexit handlers.

@brson
Copy link
Contributor Author

brson commented Sep 24, 2013

There are a few other places we're calling exit. I'll do a followup PR for them.

@bors bors closed this Sep 24, 2013
djkoloski pushed a commit to djkoloski/rust that referenced this pull request Sep 21, 2022
Add matches! checking to nonstandard_macro_braces

changelog: Enhancement: [`nonstandard_macro_braces`]: Now includes `matches!()` in the default lint config
  [rust-lang#9471](rust-lang/rust-clippy#9471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants