Skip to content

suggest removing type ascription in bad parsing position #95104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

suggest removing type ascription in bad parsing position #95104

merged 1 commit into from
Mar 21, 2022

Conversation

compiler-errors
Copy link
Member

Not sure how to test this with the non-nightly suggestion. Didn't add a new UI test because it already manifests in an existing UI test.

Fixes #95014

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 19, 2022
@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2022
davidtwco
davidtwco approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had a dig through the existing tests but nothing obvious jumped out at me as a flag/option for testing this as-if it was a stable compiler, should be fine without for this case though.

@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 21, 2022

📌 Commit 3516a16 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2022
@bors
Copy link
Collaborator

bors commented Mar 21, 2022

⌛ Testing commit 3516a16 with merge 051d117...

@bors
Copy link
Collaborator

bors commented Mar 21, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 051d117 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 21, 2022
@bors bors merged commit 051d117 into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (051d117): comparison url.

Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@compiler-errors compiler-errors deleted the remove-ascription branch April 7, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Suggest removal of type ascription in stable
6 participants
@compiler-errors @rust-highfive @davidtwco @bors @rust-timer @rustbot