Skip to content

Upgrade chalk to 0.80.0 #95233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2022
Merged

Upgrade chalk to 0.80.0 #95233

merged 2 commits into from
Mar 24, 2022

Conversation

compiler-errors
Copy link
Member

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2022
compiler-errors
compiler-errors commented Mar 23, 2022
View reviewed changes
src/test/ui/self/invalid_dispatch_from_dyn_impls.rs Outdated
@@ -1,3 +1,6 @@
// revisions: rustc chalk
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I only realize now that these tests don't do anything, I think...? Not sure how we can test these though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do any revision testing. There's compare-mode=chalk for that.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

@bors delegate+

r=me after removing revisions in tests (and just moving the tests back to where there were originally - these are probably better locations, but better for a separate PR).

Also, any way I can convince you to try let me know how many tests pass? (And maybe a delta before/after this PR?) And maybe with the recursive solver? Totally optional, but I'm curious 😉

@bors
Copy link
Collaborator

bors commented Mar 23, 2022

✌️ @compiler-errors can now approve this pull request

@compiler-errors
Copy link
Member Author

Yea I can run some tests later tonight.

@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Mar 24, 2022

📌 Commit 376d100 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2022
@bors
Copy link
Collaborator

bors commented Mar 24, 2022

⌛ Testing commit 376d100 with merge dd0e9bd58fdc3551ad67c8745551a904b24b9c56...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/next-power-of-two-overflow-debug/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/numbers-arithmetic/next-power-of-two-overflow-debug/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
------------------------------------------

@compiler-errors
Copy link
Member Author

@bors retry armhf-gpu "Connection reset by peer" -- seems unrelated

@bors
Copy link
Collaborator

bors commented Mar 24, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2022
@bors
Copy link
Collaborator

bors commented Mar 24, 2022

⌛ Testing commit 376d100 with merge 600a80d...

@compiler-errors
Copy link
Member Author

compiler-errors commented Mar 24, 2022 •
edited
Loading

Also I ran tests again. No changes to tests that pass in --compare-mode chalk, both chalk 0.76 and 0.80 report 9295 passing, 3361 failing, 108 ignored.

@bors
Copy link
Collaborator

bors commented Mar 24, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 600a80d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 24, 2022
@bors bors merged commit 600a80d into rust-lang:master Mar 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 24, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (600a80d): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@compiler-errors compiler-errors deleted the chalk-up branch April 7, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 left review comments

Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@compiler-errors @rust-log-analyzer @jackh726 @bors @rust-timer @rust-highfive @rustbot