Skip to content

Bump the ripgrep commit exercised by cargotest #95355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Mar 27, 2022

This update goes from BurntSushi/ripgrep@3de31f7 (Aug 1, 2019) to current master, BurntSushi/ripgrep@ced5b92 (March 21, 2022).

I need this in order to pick up BurntSushi/ripgrep#1722, which picked up BurntSushi/bstr#58, which unblocks #95345. Ripgrep uses the Debug representation of a BStr in some of its tests. In old versions of bstr, that used to just use the standard library's escape_debug() implementation, so the output ends up being sensitive to whether the standard library renders character 0 as \u{0} or as \0. The newer bstr always renders character 0 as \0 and ripgrep's test suite has been correspondingly updated.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2022
@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 27, 2022

📌 Commit 1431c76 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2022
@bors
Copy link
Collaborator

bors commented Mar 27, 2022

⌛ Testing commit 1431c76 with merge 100f12d...

@bors
Copy link
Collaborator

bors commented Mar 27, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 100f12d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2022
@bors bors merged commit 100f12d into rust-lang:master Mar 27, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 27, 2022
@dtolnay dtolnay deleted the ripgreptest branch March 27, 2022 22:07
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (100f12d): comparison url.

Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@dtolnay dtolnay removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants