Skip to content

Improve doc example of DerefMut #95610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2022
Merged

Improve doc example of DerefMut #95610

merged 1 commit into from
Apr 3, 2022

Conversation

createyourpersonalaccount
Copy link
Contributor

It is more illustrative, after using *x to modify the field, to show
in the assertion that the field has indeed been modified.

@createyourpersonalaccount
Improve doc example of DerefMut
53887a5 
It is more illustrative, after using `*x` to modify the field, to show
in the assertion that the field has indeed been modified.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 3, 2022

📌 Commit 53887a5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2022
@bors
Copy link
Collaborator

bors commented Apr 3, 2022

⌛ Testing commit 53887a5 with merge 2ad4eb2...

@bors
Copy link
Collaborator

bors commented Apr 3, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 2ad4eb2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 3, 2022
@bors bors merged commit 2ad4eb2 into rust-lang:master Apr 3, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 3, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2ad4eb2): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: no relevant changes found. 1 results were found to be statistically significant but too small to be relevant.
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 1 0 0 0
mean2 N/A 0.3% N/A N/A N/A
max N/A 0.3% N/A N/A N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@createyourpersonalaccount @rust-highfive @Dylan-DPC @bors @rust-timer @joshtriplett @rustbot