-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Better error for for<...>
on associated type bound
#95754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after the comments are resolved
b95e201
to
b65265b
Compare
@bors r=nagisa |
📌 Commit b65265b has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (48a9e10): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
With GATs just around the corner, we'll probably see more people trying out
Trait<for<'a> Assoc<'a> = ..>
.This PR improves the syntax error slightly, and also makes it slightly easier to make this into real syntax in the future.
Feel free to push back if the reviewer thinks this should have a suggestion on how to fix it (i.e. push the
for<'a>
outside of the angle brackets), but that can also be handled in a follow-up PR.