Skip to content

Add BoundKind in visit_param_bounds to check questions in bounds #96246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2022
Merged

Add BoundKind in visit_param_bounds to check questions in bounds #96246

merged 2 commits into from
Apr 25, 2022

Conversation

SparrowLii
Copy link
Member

@SparrowLii SparrowLii commented Apr 20, 2022 •
edited
Loading

From the FIXME in the impl of AstValidator. Better bound checks by adding BoundCtxt type parameter to visit_param_bound

cc @ecstatic-morse

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 20, 2022
@rust-highfive
Copy link
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022
compiler-errors
compiler-errors requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This is certainly better looking than the previous way. I have a few nits, then I can take a closer look and verify this works as before.

@SparrowLii
Copy link
Member Author

SparrowLii commented Apr 21, 2022 •
edited
Loading

Thanks for reviewing! I renamed BoundCtxt to BoundKind, updating names of the variants and added comments for them

@SparrowLii SparrowLii changed the title Add BoundCtxt in visit_param_bounds to check questions in bounds Add BoundKind in visit_param_bounds to check questions in bounds Apr 21, 2022
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 25, 2022

📌 Commit 38bd4fb has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2022
@bors
Copy link
Collaborator

bors commented Apr 25, 2022

⌛ Testing commit 38bd4fb with merge 7417110...

@bors
Copy link
Collaborator

bors commented Apr 25, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7417110 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2022
@bors bors merged commit 7417110 into rust-lang:master Apr 25, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7417110): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@SparrowLii @rust-highfive @compiler-errors @bors @rust-timer @rustbot