Skip to content

Sync rustc_codegen_cranelift #96323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 23, 2022
Merged

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 22, 2022

Mostly fixing bugs this time, but also a Cranelift update.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

bjorn3 and others added 28 commits March 20, 2022 16:55
It is UB for LLVM and results in a compile error for Cranelift
This PR attempts to clean up some minor spelling mistakes in comments
Address some spelling mistakes in strings, private function names, and function params.
Spellchecking some comments

This PR attempts to clean up some minor spelling mistakes in comments
This PR cleans up the rest of the spelling mistakes in the compiler comments. This PR does not change any literal or code spelling issues.
…lly initialized scalars can special case them.
check_doc_alias_value: get argument as Symbol to prevent needless string convertions

check_doc_attrs: don't alloc vec, iterate over slice. Vec introduced in rust-lang#83149, but no perf run posted on merge

replace as_str() check with symbol check

get_single_str_from_tts: don't prealloc string

trivial string to str replace

LifetimeScopeForPath::NonElided use Vec<Symbol> instead of Vec<String>

AssertModuleSource use BTreeSet<Symbol> instead of BTreeSet<String>

CrateInfo.crate_name replace FxHashMap<CrateNum, String> with FxHashMap<CrateNum, Symbol>
The main branch of Cranelift has switched to a new register allocator.
This register allocator doesn't have any alternative regalloc algorithms
unlike the old register allocator.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-codegen Area: Code generation labels Apr 22, 2022
@rustbot rustbot added the A-cranelift Things relevant to the [future] cranelift backend label Apr 22, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented Apr 22, 2022

@bors r+ subtree sync

@bors
Copy link
Collaborator

bors commented Apr 22, 2022

📌 Commit b70b01b has been approved by bjorn3

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 22, 2022
@bors
Copy link
Collaborator

bors commented Apr 23, 2022

⌛ Testing commit b70b01b with merge c212fc4...

@bors
Copy link
Collaborator

bors commented Apr 23, 2022

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing c212fc4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2022
@bors bors merged commit c212fc4 into rust-lang:master Apr 23, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 23, 2022
@bjorn3 bjorn3 deleted the sync_cg_clif-2022-04-22 branch April 23, 2022 13:27
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c212fc4): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.