Skip to content

Enable cfg checking of cargo features for everything but std #96670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 3, 2022

This PR enable cfg checking of cargo features for everything but std, it also adds a FIXME to myself.

Note: std, alloc and core imports some dependencies by #[path] (like
backtrace, core_simd, std_float, ...), those dependencies have their own features
but cargo isn't involved in the #[path] and so cannot pass the complete list of
features, so for that reason we don't enable checking of features for std.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented May 7, 2022

📌 Commit 81d2cba has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@bors
Copy link
Collaborator

bors commented May 7, 2022

⌛ Testing commit 81d2cba with merge ea92b08...

@bors
Copy link
Collaborator

bors commented May 7, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ea92b08 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2022
@bors bors merged commit ea92b08 into rust-lang:master May 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ea92b08): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants