Skip to content

Re-use the type op instead of calling the implied_outlives_bounds query directly #97081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 16, 2022

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 16, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 16, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 16, 2022
@bors
Copy link
Collaborator

bors commented May 16, 2022

⌛ Trying commit b85ebef with merge 478f542b5fc15d694bbe951c050e0f980667c115...

@bors
Copy link
Collaborator

bors commented May 16, 2022

☀️ Try build successful - checks-actions
Build commit: 478f542b5fc15d694bbe951c050e0f980667c115 (478f542b5fc15d694bbe951c050e0f980667c115)

@rust-timer
Copy link
Collaborator

Queued 478f542b5fc15d694bbe951c050e0f980667c115 with parent 56d540e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (478f542b5fc15d694bbe951c050e0f980667c115): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 8 7 8
mean2 N/A N/A -0.4% -0.3% -0.4%
max N/A N/A -0.5% -0.5% -0.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 16, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 16, 2022

Oh cool, that was an improvement on its own. Well, let's see what happens if we include a short circuit

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 16, 2022
@bors
Copy link
Collaborator

bors commented May 16, 2022

⌛ Trying commit e7a1fbc with merge b1f540c3be080f6d2647ef554a1469fc6537f225...

@bors
Copy link
Collaborator

bors commented May 16, 2022

☀️ Try build successful - checks-actions
Build commit: b1f540c3be080f6d2647ef554a1469fc6537f225 (b1f540c3be080f6d2647ef554a1469fc6537f225)

@rust-timer
Copy link
Collaborator

Queued b1f540c3be080f6d2647ef554a1469fc6537f225 with parent c52b9c1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b1f540c3be080f6d2647ef554a1469fc6537f225): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 12 13 12
mean2 N/A N/A -0.4% -0.3% -0.4%
max N/A N/A -0.6% -0.6% -0.6%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 17, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 19, 2022

r? rust-lang/compiler

@michaelwoerister
Copy link
Member

r? rust-lang/traits (I don't know what a type op is 😅)

@jackh726
Copy link
Member

jackh726 commented Jun 7, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 7, 2022

📌 Commit e7a1fbc has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2022
@bors
Copy link
Collaborator

bors commented Jun 7, 2022

⌛ Testing commit e7a1fbc with merge b17e9d7...

@bors
Copy link
Collaborator

bors commented Jun 8, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing b17e9d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 8, 2022
@bors bors merged commit b17e9d7 into rust-lang:master Jun 8, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 8, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b17e9d7): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-0.3% -0.6% 22
Improvements 🎉
(secondary)
-0.4% -0.7% 12
All 😿🎉 (primary) -0.3% -0.6% 22

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
0.6% 0.6% 1
Regressions 😿
(secondary)
3.0% 3.4% 2
Improvements 🎉
(primary)
-3.9% -3.9% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -1.7% -3.9% 2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants