-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Re-use the type op instead of calling the implied_outlives_bounds query directly #97081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b85ebef with merge 478f542b5fc15d694bbe951c050e0f980667c115... |
☀️ Try build successful - checks-actions |
Queued 478f542b5fc15d694bbe951c050e0f980667c115 with parent 56d540e, future comparison URL. |
Finished benchmarking commit (478f542b5fc15d694bbe951c050e0f980667c115): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
Oh cool, that was an improvement on its own. Well, let's see what happens if we include a short circuit @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e7a1fbc with merge b1f540c3be080f6d2647ef554a1469fc6537f225... |
☀️ Try build successful - checks-actions |
Queued b1f540c3be080f6d2647ef554a1469fc6537f225 with parent c52b9c1, future comparison URL. |
Finished benchmarking commit (b1f540c3be080f6d2647ef554a1469fc6537f225): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
r? rust-lang/compiler |
r? rust-lang/traits (I don't know what a type op is 😅) |
@bors r+ |
📌 Commit e7a1fbc has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b17e9d7): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
r? @ghost