Make -Cpasses= only apply to pre-link optimization #97969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes passes specified in -Cpasses= to be applied only during pre-link optimization, not during LTO. This avoids such passes running multiple times, which they may not be designed for. Fixes rust-lang#97713
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ This was the legacy PM behavior, so we should restore that. In the future, we might want to provide a more fine-grained way to control where the passes are inserted, but we can think about that once a use-case exists. |
|
📌 Commit 6738434 has been approved by |
bors
added
S-waiting-on-bors
|
Silently ignoring passed arguments is bad, maybe emit some error\warning? |
|
@klensy The argument is not being ignored. The passes are still inserted for the non-lto and pre-link-lto pipelines, just not the post-link-lto pipeline. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97904 (Small grammar fix in the compile_error documentation) - rust-lang#97943 (line 1352, change `self` to `*self`, other to `*other`) - rust-lang#97969 (Make -Cpasses= only apply to pre-link optimization) - rust-lang#97990 (Add more eslint checks) - rust-lang#97994 (feat(fix): update some links in `hir.rs`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes passes specified in -Cpasses= to be applied
only during pre-link optimization, not during LTO. This avoids
such passes running multiple times, which they may not be
designed for.
Fixes #97713