Skip to content

⬆️ rust-analyzer #98082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jun 14, 2022

r? @ghost

@lnicola
Copy link
Member Author

lnicola commented Jun 14, 2022

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jun 14, 2022

📌 Commit 15f6355 has been approved by lnicola

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 14, 2022
@bors
Copy link
Collaborator

bors commented Jun 14, 2022

⌛ Testing commit 15f6355 with merge da895e7...

@bors
Copy link
Collaborator

bors commented Jun 14, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing da895e7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2022
@bors bors merged commit da895e7 into rust-lang:master Jun 14, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 14, 2022
@lnicola lnicola deleted the rust-analyzer-2022-06-14 branch June 14, 2022 10:55
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (da895e7): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.1% -1.1% 2
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.1% -2.1% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-2.5% -2.7% 2
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -2.5% -2.7% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants