proc_macro/bridge: remove #[repr(C)] from non-ABI-relevant types.

[eddyb]

Not sure how this happened, maybe some of these were passed through the bridge a long time ago?

r? @bjorn3

[eddyb]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bjorn3]

The handle store seems to be used by the server at

rust/library/proc_macro/src/bridge/server.rs

Line 69 in 116201e

handle_store: HandleStore<S>,

[eddyb]

@bjorn3 Yeah but that's all server-side, it doesn't cross the client<->server ABI boundary.

[bjorn3]

I see. In that case r=me if there is no perf regression.

[mystor]

Not sure how this happened, maybe some of these were passed through the bridge a long time ago?

It wouldn't surprise me too much if at one point in the design process, the ident for TokenStream was directly passed as a function argument rather than being serialized/deserialized through a buffer.

[eddyb]

Wait, the try build never triggered?

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 83545d3 with merge 49b8138e769dd54cfcc5251d464bed219728c2c9...

[eddyb]

(spurious network failures)

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 83545d3 with merge fad3f20b02202d8b125bfde50f2aed80e525fb08...

[bors]

☀️ Try build successful - checks-actions
Build commit: fad3f20b02202d8b125bfde50f2aed80e525fb08 (fad3f20b02202d8b125bfde50f2aed80e525fb08)

[rust-timer]

Queued fad3f20b02202d8b125bfde50f2aed80e525fb08 with parent 5fb8a39, future comparison URL.

[rust-timer]

Finished benchmarking commit (fad3f20b02202d8b125bfde50f2aed80e525fb08): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.8%	-0.8%	3
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	2.7%	2.7%	1
Regressions 😿 (secondary)	3.4%	5.0%	2
Improvements 🎉 (primary)	-2.1%	-2.1%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.3%	2.7%	2

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.8%	3.8%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[bjorn3]

@bors r+

[bors]

📌 Commit 83545d3 has been approved by bjorn3

[bors]

⌛ Testing commit 83545d3 with merge 2b646bd...

[bors]

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 2b646bd to master...

[rust-timer]

Finished benchmarking commit (2b646bd): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.7%	-0.8%	4
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.9%	2.0%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	2.5%	2.5%	1
Regressions 😿 (secondary)	2.0%	2.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.5%	2.5%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³