-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove the rogue ./suggest-blanket-impl-local-trait #98791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
whoopsy @bors r+ p=5 |
📌 Commit 5f7aeb8 has been approved by |
Yeah, it's understandable. I wonder if we can check for this kind of thing in |
⌛ Testing commit 5f7aeb8 with merge 09baded8620f5bca2b0637180c64f649d003019d... |
Tidy should be checking for executables, I think, but maybe that check broke for some reason? Worth investigating for sure. |
This comment was marked as off-topic.
This comment was marked as off-topic.
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Error logs say:
Seems unrelated to whatever error rust-log-analyzer found...? @bors retry |
☀️ Test successful - checks-actions |
My bad! I did not know what I do not note I make also double check!
BTW I had the hook installed! Sorry guys! |
Finished benchmarking commit (4118ad2): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This executable was added in #97488, presumably just a
git add
mistake.