Skip to content

Conflicting instructions for pushing new commits to PRs versus amending #1058

Closed
@not-an-aardvark

Description

@not-an-aardvark

I recently opened a PR, which was my first time contributing to the rust repo. The rust-highfive bot left a comment saying, "If any changes to this PR are deemed necessary, please add them as extra commits." I think I might have read this comment initially, but then I forgot about it.

Later, when I needed to make changes to the PR, I wasn't sure whether I should amend or push additional commits, so looked at this documentation. It says, "please make sure that fixup commits are squashed into other related commits with meaningful commit messages.", which seems like the opposite of what the rust-highfive bot said. (In hindsight, I suspect maybe this is referring specifically to the the rebase process and not the process of adding fixup commits generally, but I'm only maybe 70% sure of this, and I still don't know what the recommended practice is.)

It seems like clarifying the documentation here could allow for a smoother process for future contributors/ensure that everyone is able to follow the recommended guidelines.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions