'print this book' button doesn't work

[OnlyLys]

Hi, I believe the 'print this book' button in the top right corner of the documentation doesn't work. It only prints a screenshot of the current page instead of producing a concatenated document of all the pages in the book.

[steveklabnik]

I seem to get a whole page. This also may be an mdbook bug, not a rustc-guide bug.

[mark-i-m]

@Michael-F-Bryan Do you happen to know more about this?

[phansch]

This seems to happen at least in Firefox Nightly 61 and Firefox 59.0.2. (I printed to a PDF)

[Michael-F-Bryan]

Yep, it looks like a bug in mdbook. When you go to the print page it'll show the entire book concatenated, but then when I hit ctrl+p to go to the print preview Chrome says it'll only print one page.

We've been making a couple changes to CSS lately to make the search box render nicely. My bet is that's then interfering with what the browser prints, making it think the page contents is made up of just the visible stuff. I'll create an issue on the bug tracker.

EDIT: Looks like someone beat me to it, rust-lang/mdBook#676

[mattico]

Edited with new information

The guide is using mdbook 0.1.5: https://github.com/rust-lang-nursery/rustc-guide/blob/eb396e7883e10fb4f338c881609a4f70b67bfacc/ci/install.sh#L23
I did a local build and can confirm this issue is fixed with mdbook 0.1.7.

However I did notice that if the sidebar is open the print page is shifted over 300 pixels to the right... I'll go fix that.