Skip to content

Add a note about UI test entry limitation #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

JohnTitor
Copy link
Member

rust-lang/rust#79959 added a tidy check to ensure the number of UI test entries. This PR documents it and adds a note not to place more tests on src/test/ui and src/test/ui/issues as possible.

@JohnTitor JohnTitor force-pushed the adding-ui-test-note branch from 3376e52 to 6d414bb Compare January 11, 2021 05:38
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me - there's a little duplication about how src/test/ui is big both here and on line 56 that would be nice to combine, but I'm also fine with merging as-is.

@JohnTitor JohnTitor merged commit 3e731b7 into rust-lang:master Jan 11, 2021
@JohnTitor JohnTitor deleted the adding-ui-test-note branch January 11, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants