Skip to content

Change the feature used as an example of stabilizing lib features #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Change the feature used as an example of stabilizing lib features #1143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882368f
Change the feature used as an example of stabilizing lib features
lf- Jun 12, 2021
655f7fd
Stabilizing library features: link to the PR also
lf- Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ To stabilize a feature, follow these steps:
- Add the appropriate labels: `@rustbot modify labels: +T-libs`.
- Link to the tracking issue and say "Closes #XXXXX".

You can see an example of stabilizing a feature at [#75132](https://github.com/rust-lang/rust/pull/75132).
You can see an example of stabilizing a feature at [#81656](https://github.com/rust-lang/rust/issues/81656).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section talks about how we create a PR so we should link to the PR, not the issue.

Copy link
Contributor Author

@lf- lf- Jun 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a link to both and clarified the wording so it points to all steps of the process. My understanding after talking to a t-libs member about this was that the idea of this section is to direct people to put fcp's and discussion on the merits of the feature on tracking issues prior to filing the implementation PR, to make it easier to follow.


## allow_internal_unstable

Expand Down