-
Notifications
You must be signed in to change notification settings - Fork 545
Mention that tests need a Python-enabled gdb. #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should be detecting this. cc @michaelwoerister @tromey @Mark-Simulacrum |
I think that's also a good idea. |
The failure isn't mine, I don't think. |
We should point users to the config.toml, not |
I'm talking about the configure script distributed with the gdb source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left one comment. I will wait for the discussion to converge on a decision, though.
Also, I restarted the build. It looked like a transient failure... |
I filed rust-lang/rust#56346 for this. |
The last commit addresses @mark-i-m's comment. |
Another transient test failure |
Addressed @shepmaster's comment. |
Thanks! |
As mentioned here:
rust-lang/rust#52452 (comment)
It would be good is the rust compiler guide mentioned that the compiler tests need gdb with Python support.
Are there any other test dependencies that we should mention? If there are a few, perhaps we'd even want a subsection listing them.
Thanks