Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resync config.toml and suggest better settings #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resync config.toml and suggest better settings #795
Changes from all commits
d4f978d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this from
config.toml.example
? It looks like these two lines explained why the= 0
value was set, and this was lost.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is from
config.toml.example
. I'll add it back in rust-lang/rust#76141.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Cargo documentation, the incremental default for
codegen-units
is 256, which makescodegen-units = 0
unnecessary/undesirable (unless you're compiling Rust on a machine with more than 256 hardware cores/threads, heh).So my understanding is that when adding
incremental = true
, we also need to removecodegen-units = 0
. cc @Mark-SimulacrumThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added? The default is that failures are listed at the end, without noisy output while running the tests.
EDIT: looks like the purpose of this was misunderstood? (see my other comments about
verbose-tests
)