Improve instructions for adding a new test #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a section for library tests - Expand section on rustdoc tests
jyn514
added
the
S-waiting-on-review
|
workingjubilee
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
This looks good (though obviously I don't have the relevant privileges to make much of it). I think I may have also wanted to point at https://rustc-dev-guide.rust-lang.org/tests/intro.html#compiletest-test-suites but that's nonessential.
That's already linked on the sidebar, I'm not sure where it would go in the text itself.
|
- Say what should be considered a library test - Mention adding error numbers to doc tests - Link to #ui section - Line wrapping
jyn514
force-pushed
the
jyn514-patch-1
branch
from
07c047f to
00b595a
Compare
JohnTitor
reviewed
Sep 16, 2020
It shouldn't have been a link in the first place. Co-authored-by: Yuki Okushi <[email protected]>
JohnTitor
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From rust-lang/rust#76268 (comment)