Skip to content

updated link for Citizen Code of Conduct #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

updated link for Citizen Code of Conduct #959

merged 2 commits into from
Nov 16, 2020

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Nov 12, 2020

This PR updates the broken link of the Code of Conduct from http://citizencodeofconduct.org to https://github.com/stumpsyn/policies/blob/master/citizen_code_of_conduct.md as discussed for other occurrences in the rust repositories in rust-lang/www.rust-lang.org#1212 and implemented via rust-lang/www.rust-lang.org#1215.

Additionally it switches from using HTML linking to using native markdown syntax.

@jyn514
Copy link
Member

jyn514 commented Nov 12, 2020

Hmm, looking at the issue it seems the eventual plan is to inline the Citizen code of conduct into the Rust version? I think it might make sense rather than having our own copy to link to the version on the website, that way we don't have to keep them in sync.

@Shegox
Copy link
Contributor Author

Shegox commented Nov 13, 2020

Alternatively we could as well replace the whole CODE_OF_CONDUCT with just a link to the online version like the rust-lang/rust repository it does (see rust-lang/rust#65141):

# The Rust Code of Conduct

The Code of Conduct for this repository [can be found online](https://www.rust-lang.org/conduct.html).

@jyn514
Copy link
Member

jyn514 commented Nov 13, 2020

@Shegox sounds great! Can you do that?

@Shegox
Copy link
Contributor Author

Shegox commented Nov 16, 2020

@jyn514 updated the CODE_OF_CONDUCT to point to https://www.rust-lang.org/conduct.html

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one small nit about the wording :)

Co-authored-by: Joshua Nelson <[email protected]>
@Shegox
Copy link
Contributor Author

Shegox commented Nov 16, 2020

Done @jyn514, thanks a lot!

@jyn514 jyn514 merged commit 950e4a4 into rust-lang:master Nov 16, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 16, 2020

Thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants