Miscellaneous site crate cleanups
#1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the convention for handlers which have an associated `api::xxx::Response` object.
This is a bit neater and enables support for the previously non-functioning `cid` parameter on the raw profile endpoint (support for the processed profile endpoint will be added in a later commit).
It's always false, and we don't really need to worry about backwards compatibility with clients in the wild, so remove it.
Instead of reusing `self_profile_raw` request and response types, use separate `self_profile_processed` types. Also, remove `get_self_profile_raw` and use serde to deserialize requests, which automatically enables support for the previously non-functioning `cid` parameter.
|
By the way, I smoke-tested the changes locally. E.g. self profile endpoints still parse the existing query parameter formats correctly and will pass along additional parameters to crox, etc. |
|
Looks good to me. Let's merge this in, and we can always fix any issues that come up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous
sitecleanups, including unused and duplicated code removal, increased consistency, simplification.