Use new significance algorithm by default #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
requested changes
Oct 4, 2021
Mark-Simulacrum
force-pushed
the
new-sig-default
branch
from
11bae6c to
58e22b2
Compare
|
Alright, replaced with just swapping the default, I believe. |
Mark-Simulacrum
force-pushed
the
new-sig-default
branch
from
58e22b2 to
96c72a9
Compare
|
Yes, yes. Sorry for being so bad at identifying these places :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently just completely removes the old algorithm (at least where it was if-gated). I think we could allow switching back, but I've not really seen a use case for that (you can always disable filtering by significance in the UI).