Add cargo-0.60.0 as a new benchmark.
#1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
add-new-cargo
branch
from
094377a to
2f36557
Compare
Mark-Simulacrum
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
This looks good to me (I didn't try to confirm this exactly reproduces Cargo, but seems OK -- we may, I suppose, want to move to some kind of crates.io download + set of patches system to avoid inlining a bunch of raw files, but that has its own annoyances).
It looks like it needs a rebase and I'd like to hold off on merging until we make sure that we have some spare time in our builder (after the style-servo removal I just merged).
I obtained the code with: ``` target/release/collector download -c primary crate cargo 0.60.0 ``` `cargo-0.60.0/perf-config.json` and `cargo-0.60.0/0-println.patch` are based on the corresponding files in `cargo/`. `cargo-0.60.0` is quite a bit slower to compile than `cargo`. Times for `full` builds of the final crate on my machine: ``` cargo cargo-0.60.0 cargo check 4.26 6.92 cargo debug 10.13 19.72 cargo opt 17.59 35.67 ``` And to run the entire benchmark (including compiling all crates): ``` cargo: Check real 18.46 user 84.04 sys 18.01 cargo-0.60.0: Check real 18.16 user 100.21 sys 13.45 cargo: Debug real 25.98 user 163.99 sys 21.99 cargo-0.60.0: Debug real 32.92 user 205.82 sys 18.37 cargo: Opt real 38.28 user 450.19 sys 20.37 cargo-0.60.0: Opt real 55.54 user 585.34 sys 19.06 ``` `cargo` will be removed soon.
nnethercote
force-pushed
the
add-new-cargo
branch
from
2f36557 to
e2cdeec
Compare
|
I have rebased. |
rylev
approved these changes
Mar 17, 2022
|
Going to merge since I think the builder has had time to recover. |
nnethercote
added a commit
to nnethercote/rustc-perf
that referenced
this pull request
Mar 17, 2022
This should have been part of rust-lang#1209.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I obtained the code with:
cargo-0.60.0/perf-config.jsonandcargo-0.60.0/0-println.patcharebased on the corresponding files in
cargo/.cargo-0.60.0is quite a bit slower to compile thancargo. Times forfullbuilds of the final crate on my machine:And to run the entire benchmark (including compiling all crates):
cargowill be removed soon.