Skip to content

Always include next steps in GitHub message #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Apr 25, 2022

Fixes #1307

Before this change, the next steps instructions (which include label changes and bors directives) were only showed if the results were relevant. However, we should always show next steps even if the results aren't relevant.

This has a few interesting changes to current behavior:

  • The S-waiting-on-perf label will be removed when the try run finishes
  • Even PRs that show no relevant perf changes will still be labeled as @bors rollup=never
  • The perf-regression label will be removed if the run returns no relevant perf results

All these changes are how things worked in the past, and I believe are the right behavior.

@rylev rylev requested review from Kobzol and Mark-Simulacrum April 25, 2022 09:44
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm not sure if adding +S-waiting-on-review after each try run is always correct, but that's not for the current PR.

@rylev rylev merged commit 9efb478 into rust-lang:master Apr 25, 2022
@rylev rylev deleted the always-next-steps branch April 25, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If perf run completed without any relevant results, github tag S-waiting-on-perf didn't removed
2 participants