Skip to content

Make unrolled commit message more descriptive #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2022
Merged

Make unrolled commit message more descriptive #1381

merged 3 commits into from
Aug 2, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 2, 2022 •
edited
Loading

The commit message was previously merged. Now it is Unrolled build for #1000.

This also contains a small refactor that made this easier to implement.

Additionally, two more changes have been added:

  • Making the entire unrolling logic independent of the merge event. This was originally opened as Make unrolling independent of the merge event #1382.
  • Fix an issue whereby we were only building the first sha when many @rust-timer build messages were in a comment.

@rylev rylev requested a review from Mark-Simulacrum August 2, 2022 09:11
@rylev rylev mentioned this pull request Aug 2, 2022
Closed
@Mark-Simulacrum Mark-Simulacrum merged commit b7b11a6 into rust-lang:master Aug 2, 2022
@rylev rylev deleted the better-commit-message branch August 2, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylev @Mark-Simulacrum