Skip to content

Add comment about unifying types to Profile #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add comment about unifying types to Profile #1518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions collector/src/benchmark/profile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/// Type of compilation used for benchmarking/profiling.
// Note: This type is very similar to the definition of a profile in the database crate.
// However, these types should not be unified, as they serve slightly different purposes.
// This type is used for specifying profiles to be benchmarked using the CLI, which is not relevant
// to the database crate.
// In general, the database versions of types used in the collector should be considered a DB
// implementation detail, as they may change when we alter database layout.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, clap::ArgEnum, serde::Deserialize)]
#[clap(rename_all = "PascalCase")]
pub enum Profile {
Expand Down