Skip to content

Add CI workflow for benchmarking Cranelift backend #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 14, 2023

This PR adds a CI workflow that checks whether we can run benchmarks using the Cranelift backend. It also adds support for downloading the Cranelift backend component in install_nexŧ.

@Kobzol Kobzol force-pushed the ci-codegen-backend branch 2 times, most recently from aacefa2 to f53df1f Compare December 14, 2023 21:54
@Kobzol Kobzol marked this pull request as draft December 14, 2023 22:10
@Kobzol Kobzol force-pushed the ci-codegen-backend branch from f53df1f to d65049e Compare December 15, 2023 15:55
@Kobzol Kobzol marked this pull request as ready for review December 15, 2023 15:55
@Kobzol Kobzol force-pushed the ci-codegen-backend branch from d65049e to d6c617a Compare December 15, 2023 15:58
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but let's try to deploy this in the 2nd half of the day (ET) or on the weekend so I can fix the collector if needed. The download code isn't really automated today in terms of recovery from faults.

@Kobzol
Copy link
Contributor Author

Kobzol commented Dec 19, 2023

I don't think that this should affect the server collector at all (?). It doesn't use install_next.

@Mark-Simulacrum
Copy link
Member

Ah, then feel free to merge whenever. I think I misremembered - we use bench_next looks like: https://github.com/rust-lang/rustc-perf/blob/master/collector/collect.sh#L25

@Kobzol Kobzol merged commit 1c32479 into rust-lang:master Dec 19, 2023
@Kobzol Kobzol deleted the ci-codegen-backend branch December 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants