Add binary size local command shortcut to benchmark detail #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
binary-size-cmd-shortcut
branch
from
f0725b2 to
cea342e
Compare
lqd
approved these changes
Dec 18, 2023
site/frontend/src/pages/compare/compile/table/shortcuts/cachegrind-cmd.vue
Outdated
Show resolved
Hide resolved
site/frontend/src/pages/compare/compile/table/shortcuts/profile-shortcut.vue
Show resolved
Hide resolved
site/frontend/src/pages/compare/compile/table/shortcuts/binary-size-shortcut.vue
Show resolved
Hide resolved
lqd
reviewed
Dec 18, 2023
Kobzol
force-pushed
the
binary-size-cmd-shortcut
branch
from
cea342e to
0fdfc9e
Compare
|
Added and expanded comments 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command shortcut for analyzing binary size locally using the new
binary_statscommand to the benchmark detail panel.