Add instructions for installing rustup-toolchain-install-master #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Hi, thanks for the PR! It depends not so much on the command that you execute, but more on the toolchain type that you use, if you give a SHA, you need this tool.
So claiming that you need the tool for bench_local/profile_local everytime is a bit misleading. Maybe we could instead specify on a single place (e.g. at the beginning of the section with the available commands) that if you want to specify a toolchain with a commit SHA, you will need this tool.
chengr4
force-pushed
the
collector-readme
branch
3 times, most recently
from
3c43c95 to
4653bb2
Compare
chengr4
force-pushed
the
collector-readme
branch
from
4653bb2 to
3722078
Compare
|
Thanks for clarifying. In that case, I believe the original one is good enough. I've made the updates and just adjusted the style a bit. What do you think? |
Kobzol
approved these changes
Mar 8, 2024
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
./target/release/collector profile_local XXXXXXXX, it also asked me to install the tool.