Improve message printed when the site starts #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me. It would be fine to say "N things, of which X are this and Y are that", I think, but it's not clear that's actually more informative. |
|
If you run the website locally, you will usually not have any commits in the DB anyway (unless you have downloaded a DB dump from the live server). And for the user of the website, the distinction isn't actually important, for the compare page both commits and artifacts are mostly equal. So I'd opt into using the simpler variant with a single number. |
|
If the distinction is mostly useless even to those who might care about it, that makes sense, yeah! |
lqd
approved these changes
Mar 19, 2024
The distinction between commits and artifacts is confusing (local compiler versions were actually under artifacts).
Kobzol
force-pushed
the
cli-improve-message
branch
from
5cd7b58 to
e2ee3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction between commits and artifacts is confusing (local compiler versions were actually under artifacts).