-
Notifications
You must be signed in to change notification settings - Fork 152
Add typenum-1.17.0
benchmark
#1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add typenum
to the list in collector/compile-benchmarks/README.md
?
d44fa17
to
46693de
Compare
Added it there, good catch. |
46693de
to
e66a275
Compare
I also removed one generated file that had 20k lines, but wasn't actually needed for compilation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except I don't think the README needs all the reindenting.
Sorry, my IntelliJ now defaults to "auto-format everything in a file on every save", I haven't changed the default for this project, which caused this mess. I'll fix it tomorrow. |
Heh, it did smell like an autoformatting thing. |
e66a275
to
f2941e9
Compare
This PR adds the
typenum
crate as a primary benchmark. It is a very popular crate (300k daily downloads, top 100 crates.io) that stresses the trait solver in unusual ways.All configurations of the benchmark are finished in ~10 seconds locally with
bench_local
.Closes: #1873