Skip to content

Add typenum-1.17.0 benchmark #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 22, 2024

This PR adds the typenum crate as a primary benchmark. It is a very popular crate (300k daily downloads, top 100 crates.io) that stresses the trait solver in unusual ways.

All configurations of the benchmark are finished in ~10 seconds locally with bench_local.

Closes: #1873

@Kobzol Kobzol requested a review from nnethercote March 22, 2024 09:49
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add typenum to the list in collector/compile-benchmarks/README.md?

@Kobzol Kobzol force-pushed the benchmark-typenum branch from d44fa17 to 46693de Compare March 23, 2024 13:23
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 23, 2024

Added it there, good catch.

@Kobzol Kobzol force-pushed the benchmark-typenum branch from 46693de to e66a275 Compare March 23, 2024 13:29
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 23, 2024

I also removed one generated file that had 20k lines, but wasn't actually needed for compilation.

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except I don't think the README needs all the reindenting.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 24, 2024

Sorry, my IntelliJ now defaults to "auto-format everything in a file on every save", I haven't changed the default for this project, which caused this mess. I'll fix it tomorrow.

@nnethercote
Copy link
Contributor

Heh, it did smell like an autoformatting thing.

@Kobzol Kobzol force-pushed the benchmark-typenum branch from e66a275 to f2941e9 Compare March 25, 2024 08:10
@Kobzol Kobzol enabled auto-merge March 25, 2024 08:11
@Kobzol Kobzol merged commit b990542 into rust-lang:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a benchmark for typenum
2 participants