Skip to content

Clarify local development setup #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2024
Merged

Clarify local development setup #1877

merged 1 commit into from
Mar 23, 2024

Conversation

chengr4
Copy link
Contributor

@chengr4 chengr4 commented Mar 23, 2024

Close #1874

Please confirm whether the update is appropriate.

Kobzol
Kobzol reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't incorporate it, you still need to execute cargo build or cargo run manually. The important info is that if you want to develop locally, you should use watch + cargo run, without --release.

@chengr4 chengr4 force-pushed the update-instruction branch from 41f5d2b to 1971b8b Compare March 23, 2024 15:34
@chengr4
Copy link
Contributor Author

chengr4 commented Mar 23, 2024

How about this?

Kobzol
Kobzol approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one extra word, otherwise LGTM.

@chengr4 chengr4 force-pushed the update-instruction branch from 1971b8b to 80f01a1 Compare March 23, 2024 15:58
Kobzol
Kobzol approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Kobzol Kobzol enabled auto-merge March 23, 2024 15:59
@Kobzol Kobzol merged commit c836192 into rust-lang:master Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seeking faster ways to open the frontend
2 participants
@chengr4 @Kobzol