Skip to content

Triage for this week #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions triage/2024-07-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
# 2024-07-21 Triage Log

Light week, with few changes on any dimension (including memory), though
overall a slight regression.

Triage done by **@simulacrum**.
Revision range: [5572759b..9629b90b](https://perf.rust-lang.org/?start=5572759b8d7012fa34eba47f4885c76fa06d9251&end=9629b90b3f7dd8f5626ec9d3b42556f39f09e214&absolute=false&stat=instructions%3Au)

**Summary**:

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.8%] | 6 |
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 7.3%] | 13 |
| Improvements ✅ <br /> (primary) | -0.7% | [-0.9%, -0.5%] | 6 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.1% | [-0.9%, 0.8%] | 12 |

1 Regression, 1 Improvement, 1 Mixed; 2 of them in rollups
34 artifact comparisons made in total

#### Regressions

Rollup of 8 pull requests [#127865](https://github.com/rust-lang/rust/pull/127865) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fcc325f1bc477975e2ce5ba534fe4c77ff8a8536&end=e35364a521372ce682e4bd4a5850d97ea33b0eab&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:----:|:------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.7%] | 4 |
| Regressions ❌ <br /> (secondary) | 1.1% | [0.6%, 2.1%] | 7 |
| Improvements ✅ <br /> (primary) | - | - | 0 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.6% | [0.4%, 0.7%] | 4 |

Clear regression, though contributing PR from the rollup is not clear. Started
a build to try to dig deeper.

#### Improvements

Represent type-level consts with new-and-improved `hir::ConstArg` [#125915](https://github.com/rust-lang/rust/pull/125915) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3d68afc9e821b00d59058abc9bda670b07639955&end=8c3a94a1c79c67924558a4adf7fb6d98f5f0f741&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | - | - | 0 |
| Regressions ❌ <br /> (secondary) | - | - | 0 |
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.5%] | 6 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.5%] | 6 |


#### Mixed

Rollup of 9 pull requests [#127998](https://github.com/rust-lang/rust/pull/127998) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=41ff4608894d260462a7b6cf1ddefc6c8ecf6b1c&end=1afc5fd042f7583b9668dd62be98325487483d1c&stat=instructions:u)

| (instructions:u) | mean | range | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
| Regressions ❌ <br /> (secondary) | 1.3% | [1.3%, 1.3%] | 1 |
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 1 |
| Improvements ✅ <br /> (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.1% | [-0.7%, 0.3%] | 3 |

Clear regression, though contributing PR from the rollup is not clear. Started
a build to try to dig deeper.
Loading