collector: passthrough env vars #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the collector to stop clearing the environment when invoking the fake rustc. This is helpful for users of Nix development shells where environment variables are required to inform tools of the location of C dependencies, and for setting RUSTFLAGS to collect data from the same build with different flags. However, this change can result in some environment variables affecting the data collection where that isn't intended. Signed-off-by: David Wood <[email protected]>
|
I'm going to go ahead and merge this -- I think it's probably the right thing to do. I wonder if we should instead have some sort of "allowed env list" in the arguments passed to the executable... but that seems pretty annoying for users who do want some stable set of env variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the collector to stop clearing the environment when invoking the fake rustc.
This is helpful for users of Nix development shells where environment variables are required to inform tools of the location of C dependencies, and for setting
RUSTFLAGSto collect data from the same build with different flags.However, this change can result in some environment variables affecting the data collection where that isn't intended.