Skip to content

fix time diff #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021
Merged

fix time diff #845

merged 1 commit into from
Feb 26, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 26, 2021

Currently at https://perf.rust-lang.org/status.html
time shown as

No current collection in progress. Last one finished at 2/26/2021, 7:30:10 PM local time, -14m0-31s ago.

so fixing last portion to real time diff.

@Mark-Simulacrum
Copy link
Member

Hm, have you tested this locally? This has bothered me for a while, but it feels like moving the division isn't the right fix - I'd expect flipping end and the current time to be closer to the right fix?

@klensy
Copy link
Contributor Author

klensy commented Feb 26, 2021

You can check values: end in milliseconds, new Date() in milliseconds too, but new Date()/1000 - end will be negative, you can check that in js debugger.

@klensy
Copy link
Contributor Author

klensy commented Feb 26, 2021

format_duration(Math.trunc((new Date()/1000 - end)))
" -55m0-45s"
format_duration(Math.trunc((new Date() - end)/1000))
"1h20m57s"

@Mark-Simulacrum
Copy link
Member

Hm, ok. Thanks. CI is a different bug, unrelated to this, so going to go ahead and merge.

@Mark-Simulacrum Mark-Simulacrum merged commit 4347ba8 into rust-lang:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants