fix timings order across browsers #847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently order if timing differs in different browsers. For example, check this page in chrome and firefox https://perf.rust-lang.org/compare.html?start=15598a83db88ec7a32ea18a44dd6309f32edc07e&end=f288a8e816163b97425adb1baca86b573395e3ec , you can see that in chrome, bootstrap timings goes first, but in firefox - last.
Fixes by setting
is_bootstrap=false
for non bootstrap, and then sorting (asis_bootstrap
becametrue\false
always, instead being none sometimes).