Rust triage generation api #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this intended to be used from perf.rust-lang.org or a local instance? Deriving the username from the home dir suggests that it is meant to be run locally, but the request handler doesn't gate it to local instances. Also the use of the api token is not rate limited, which makes abuse very easy. |
bjorn3
reviewed
Jun 8, 2021
bjorn3
reviewed
Jun 8, 2021
|
We don't currently worry too much about rate limiting across any of the Rust-run services other than crates.io, though it's definitely debt that we're putting in place. I wouldn't worry about it for the purposes of this PR. |
|
Alright, let's merge this in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API for generating the triage report.