Update deps (including tokio to 1.x) #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! I think the PR description may no longer be valid as you've inlined the logic from that crate? If so, I am OK merging this -- I'll probably try to make note of when I do so in case it causes any differences in site or collector performance (that wouldn't be expected but we are updating a lot of stuff). |
|
@Mark-Simulacrum correct. This is now ready to merge. 😊 Let me know how you want to monitor things, and I can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is ready for review, but not ready to merge. We first need to update Mark-Simulacrum/rustc-artifacts to use the latest version ofreqwest. Without that change this change does not work.