Refactorings for enabling parallel compilation (part 2) #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently doesn't have any optimizations at all.
It isn't actually wired up and temporarily removing it will make changes to the debuginfo generation code much simpler.
And explicitly thread it through everwhere it is needed.
This is a correctness fix
This will make it easier to move TyCtxt requiring operations before clif ir compilation.
This removes the dependency on TyCtxt from the debuginfo finalization code.
bjorn3
added
C-enhancement
|
Before merging this I'm going to benchmark it first as I'm not entirely sure about the perf implications of 6421427. |
|
Doesn't seem to have changed much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of refactorings to remove dependencies on TyCtxt and Session for various functions that will in the future be called on background threads as those types are only available on the main thread. Most of this PR concerns the debuginfo generation code, but there are also a couple of refactorings to other code.
Part of #652
See #1264 for the previous PR in this series and #1271 for the next PR.