Skip to content

Set rustup profile to minimal #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Set rustup profile to minimal #1516

merged 2 commits into from
Jul 14, 2024

Conversation

lqd
Copy link
Member

@lqd lqd commented Jul 14, 2024

This PR fixes #1511 by setting the minimal profile in the toolchain file, and removing the explicit places where this was already done in CI scripts.

I don't think using rustup set profile minimal as you mention in the issue works when there's already a rustup override file: I believe the override kinda sets the profile back to its default value.

lqd added 2 commits July 14, 2024 07:32
the minimal profile is already set in the rust-toolchain file
@lqd
Copy link
Member Author

lqd commented Jul 14, 2024

Ah I didn't notice there was an open PR to fix the same issue. But since it's using the rustup set profile minimal trick, we can verify my assumption that it wouldn't work.

In that PR, for example in the ubuntu-20.04 dist job, components that are not in the minimal profile are still being downloaded:

info: downloading component 'rust-docs'

Compared to using the rust-toolchain file, in this PR's same job which does look to be correctly set to "minimal".

@bjorn3 bjorn3 merged commit 5203b7e into rust-lang:master Jul 14, 2024
20 checks passed
@lqd lqd deleted the rustup-profile branch July 14, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use minimal rustup profile in CI
2 participants