Skip to content

Properly format macro's with an extra ident #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Properly format macro's with an extra ident #883

merged 1 commit into from
Mar 30, 2016

Conversation

marcusklaas
Copy link
Contributor

Fixes #806.

let macro_name = format!("{}!", mac.node.path);
let macro_name = match extra_ident {
Some(ast::Ident { name: ast::Name(0), .. }) => format!("{}!", mac.node.path),
None => format!("{}!", mac.node.path),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we 'or' together these two arms?

@nrc
Copy link
Member

nrc commented Mar 28, 2016

r+ with the nit addressed (yay! for better macro support)

@marcusklaas marcusklaas merged commit 50820c6 into rust-lang:master Mar 30, 2016
@marcusklaas marcusklaas deleted the macro-with-name branch March 30, 2016 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants