Changed modules & visitor mods to public, set filemap::write_file public #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ pub fn write_system_newlines<T>(writer: T, | |||
| } | |||
| } | |||
|
|
|||
| fn write_file<T>(text: &StringBuffer, | |||
| pub fn write_file<T>(text: &StringBuffer, | |||
| filename: &str, | |||
There was a problem hiding this comment.
please adjust the indentation on following lines (surprised this doesn't fail tests)
might it be better to pull this function up rather than making the whole module public? |
|
@nrc, Currently the only content of that module are that method and two (non-public) helper methods, so the net effect is the same. Just tell me which you'd prefer. |
|
Ok, then how it is in the PR seems fine |
DanielJCampbell
force-pushed
the
visibility
branch
from
2fee54d to
4a2db3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to improve rustfmt usability as a library - FmtVisitor made public so users can format without having to plug into the main format methods in lib, write file is public to give more control over output filenames/locations, modules is public to allow access to list_files (used to format a file with the visitor).