Add option to mount the source directory read-write #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `Command::source_dir_mount_kind` method to provide the ability to mount the source directory as read-write. This is needed for the testing that we want to do in crater to test `cargo fix` and edition migrations. This is needed because `cargo fix` inherently needs to modify the source directory.
syphar
approved these changes
May 31, 2025
|
@ehuss there is a pending security fix I want to add to the next release, hopefully merged the next days, feel free to ping me if you need an earlier release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Command::source_dir_mount_kindmethod to provide the ability to mount the source directory as read-write. This is needed for the testing that we want to do in crater to testcargo fixand edition migrations. This is needed becausecargo fixinherently needs to modify the source directory.