-
Notifications
You must be signed in to change notification settings - Fork 289
Rust does not let you observe or mutate the floating-point register in well-defined ways #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1365,6 +1365,15 @@ pub unsafe fn _mm_sfence() { | |
|
||
/// Gets the unsigned 32-bit value of the MXCSR control and status register. | ||
/// | ||
/// Note that Rust makes no guarantees whatsoever about the contents of this regiser: Rust | ||
/// floating-point operations may or may not result in this register getting updated with exception | ||
/// state, and the register can change between two invocations of this function even when no | ||
/// floating-point operations appear in the source code (since floating-point operations appearing | ||
/// earlier or later can be reordered). | ||
/// | ||
/// If you need to perform some floating-point operations and check whether they raised an | ||
/// exception, use an inline assembly block for the entire sequence of operations. | ||
/// | ||
/// For more info see [`_mm_setcsr`](fn._mm_setcsr.html) | ||
/// | ||
/// [Intel's documentation](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_getcsr) | ||
|
@@ -1401,6 +1410,16 @@ pub unsafe fn _mm_getcsr() -> u32 { | |
/// * The *denormals-are-zero mode flag* turns all numbers which would be | ||
/// denormalized (exponent bits are all zeros) into zeros. | ||
/// | ||
/// Note that modfying the masking flags, rounding mode, or denormals-are-zero mode flags leads to | ||
RalfJung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// **immediate Undefined Behavior**: Rust assumes that these are always in their default state and | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes this function basically impossible to use in a UB-free way. Should we deprecate it in favor of inline assembly blocks? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I don't see why we wouldn't. As far as I can tell this function always either has no effect or is UB to call |
||
/// will optimize accordingly. This even applies when the register is altered and later reset to its | ||
/// original value without any floating-point operations appearing in the source code between those | ||
/// operations (since floating-point operations appearing earlier or later can be reordered). | ||
/// | ||
/// If you need to perform some floating-point operations under a different masking flags, rounding | ||
/// mode, or denormals-are-zero mode, use an inline assembly block and make sure to restore the | ||
/// original MXCSR register state before the end of the block. | ||
/// | ||
/// ## Exception Flags | ||
/// | ||
/// * `_MM_EXCEPT_INVALID`: An invalid operation was performed (e.g., dividing | ||
|
Uh oh!
There was an error while loading. Please reload this page.