x86: fixed testing equality of floating point numbers #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like CI is failing though? |
|
It was still building when I went sleep. I haven't marked the new auxiliary macro as used only in tests, so normal build emitted unused macro warning. Now it should be fixed. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have run the tests and five of them failed. I checked the Intel Intrinsics Guide and it said that these specific instructions returns approximated values while the tests don't take the error into account. I have Ryzen 1700X. I guess all of test runs until now could be done on Intel CPUs where it could possibly always return those hardcoded specific values.
I also haven't known how to cleanly make the compare, so I have added an extra macro. It is basically copy-paste of this since I didn't want to add new dependencies.